No description
Find a file
Zettat123 6b74043b85
Fix missing signature key error when pulling Docker images with SERVE_DIRECT enabled (#32365)
Fix #28121

I did some tests and found that the `missing signature key` error is
caused by an incorrect `Content-Type` header. Gitea correctly sets the
`Content-Type` header when serving files.

348d1d0f32/routers/api/packages/container/container.go (L712-L717)
However, when `SERVE_DIRECT` is enabled, the `Content-Type` header may
be set to an incorrect value by the storage service. To fix this issue,
we can use query parameters to override response header values.

https://docs.aws.amazon.com/AmazonS3/latest/API/API_GetObject.html
<img width="600px"
src="https://github.com/user-attachments/assets/f2ff90f0-f1df-46f9-9680-b8120222c555"
/>

In this PR, I introduced a new parameter to the `URL` method to support
additional parameters.

```
URL(path, name string, reqParams url.Values) (*url.URL, error)
```

---

Most S3-like services support specifying the content type when storing
objects. However, Gitea always use `application/octet-stream`.
Therefore, I believe we also need to improve the `Save` method to
support storing objects with the correct content type.

b7fb20e73e/modules/storage/minio.go (L214-L221)
(cherry picked from commit 0690cb076bf63f71988a709f62a9c04660b51a4f)

Conflicts:
	- modules/storage/azureblob.go
	  Dropped the change, as we do not support Azure blob storage.
	- modules/storage/helper.go
	  Resolved by adjusting their `discardStorage` to our
	  `DiscardStorage`
	- routers/api/actions/artifacts.go
	  routers/api/actions/artifactsv4.go
	  routers/web/repo/actions/view.go
	  routers/web/repo/download.go
	  Resolved the conflicts by manually adding the new `nil`
	  parameter to the `storage.Attachments.URL()` calls.

	  Originally conflicted due to differences in the if expression
	  above these calls.
2024-11-05 09:33:15 +01:00
.devcontainer Update ghcr.io/devcontainers/features/git-lfs Docker tag to v1.2.3 2024-10-01 10:02:11 +00:00
.forgejo Update renovate to v38.142.5 (forgejo) (#5802) 2024-11-04 05:52:26 +00:00
assets chore(license): Update module github.com/gorilla/sessions to v1.4.0 2024-11-03 09:00:22 +01:00
build refactor: remove redundant err declarations (#32381) 2024-11-05 09:33:15 +01:00
cmd chore: fix some function names in comment (#32300) 2024-10-27 10:35:48 +01:00
contrib
custom/conf Add new [lfs_client].BATCH_SIZE and [server].LFS_MAX_BATCH_SIZE config settings. (#32307) 2024-11-05 09:33:15 +01:00
docker
models refactor: remove redundant err declarations (#32381) 2024-11-05 09:33:15 +01:00
modules Fix missing signature key error when pulling Docker images with SERVE_DIRECT enabled (#32365) 2024-11-05 09:33:15 +01:00
options i18n(en): improvements to some strings (#5767) 2024-11-02 11:06:35 +00:00
public Merge pull request 'Do not change stroke size in the loading animation' (#5506) from kytta/forgejo:forgejo-loading-stroke into forgejo 2024-10-25 17:24:16 +00:00
release-notes chore(release-notes): related pull requests workflow fixes 2024-11-04 12:10:15 +01:00
releases/images
routers Fix missing signature key error when pulling Docker images with SERVE_DIRECT enabled (#32365) 2024-11-05 09:33:15 +01:00
services Fix missing signature key error when pulling Docker images with SERVE_DIRECT enabled (#32365) 2024-11-05 09:33:15 +01:00
templates Fix the missing menu in organization project view page (#32313) 2024-11-05 09:33:15 +01:00
tests fix: Actions PR workflows must update the commit status 2024-11-04 11:27:14 +01:00
tools chore: move to Eslint flat config 2024-10-23 15:28:43 +02:00
web_src Merge pull request '[PORT] Fix a number of typescript issues (gitea#32308)' (#5791) from gusted/forgejo-port-32308 into forgejo 2024-11-04 08:44:57 +00:00
.air.toml
.deadcode-out [PORT] Fix git error handling (gitea#32401) 2024-11-03 16:47:44 +01:00
.dockerignore
.editorconfig
.envrc
.gitattributes
.gitignore
.gitmodules
.gitpod.yml
.golangci.yml
.ignore
.mailmap
.markdownlint.yaml
.npmrc
.release-notes-assistant.yaml chore(release-notes): no need to specify they are draft 2024-10-22 06:54:27 +02:00
.spectral.yaml
.yamllint.yaml
BSDmakefile
build.go
CODEOWNERS docs(e2e): Update e2e test instructions for changed file patterns 2024-10-04 15:15:10 +02:00
CONTRIBUTING.md
DCO
Dockerfile Dockerfile: use alpine:3.20 instead of golang:1.23-alpine3.20 2024-10-16 22:04:26 +02:00
Dockerfile.rootless Dockerfile: use alpine:3.20 instead of golang:1.23-alpine3.20 2024-10-16 22:04:26 +02:00
eslint.config.mjs Add typescript 2024-10-29 18:15:09 +01:00
flake.lock
flake.nix
go.mod Update module github.com/gorilla/sessions to v1.4.0 2024-11-03 00:04:40 +00:00
go.sum Update module github.com/gorilla/sessions to v1.4.0 2024-11-03 00:04:40 +00:00
LICENSE
main.go
Makefile Update renovate to v38.142.5 (forgejo) (#5802) 2024-11-04 05:52:26 +00:00
package-lock.json Merge pull request 'Update linters to v8.13.0 (forgejo)' (#5815) from renovate/forgejo-linters into forgejo 2024-11-05 07:53:47 +00:00
package.json Merge pull request 'Update linters to v8.13.0 (forgejo)' (#5815) from renovate/forgejo-linters into forgejo 2024-11-05 07:53:47 +00:00
playwright.config.ts Add typescript 2024-10-29 18:15:09 +01:00
poetry.lock Lock file maintenance (forgejo) (#5804) 2024-11-04 05:54:02 +00:00
poetry.toml
pyproject.toml Update dependency djlint to v1.35.4 2024-11-02 00:03:16 +00:00
README.md
release-notes-assistant.sh chore(release-notes-assistant): update internationalization label (#5698) 2024-10-25 14:36:22 +00:00
RELEASE-NOTES.md docs: add links to the v7.0.10 & v9.0.1 release notes 2024-10-28 09:08:48 +01:00
renovate.json chore(renovate): explicit base branches 2024-11-01 13:00:55 +01:00
stylelint.config.js
tailwind.config.js
tsconfig.json Add typescript 2024-10-29 18:15:09 +01:00
vitest.config.ts Add typescript 2024-10-29 18:15:09 +01:00
webpack.config.js Add typescript 2024-10-29 18:15:09 +01:00

Welcome to Forgejo

Hi there! Tired of big platforms playing monopoly? Providing Git hosting for your project, friends, company or community? Forgejo (/for'd͡ʒe.jo/ inspired by forĝejo the Esperanto word for forge) has you covered with its intuitive interface, light and easy hosting and a lot of builtin functionality.

Forgejo was created in 2022 because we think that the project should be owned by an independent community. If you second that, then Forgejo is for you! Our promise: Independent Free/Libre Software forever!

What does Forgejo offer?

If you like any of the following, Forgejo is literally meant for you:

  • Lightweight: Forgejo can easily be hosted on nearly every machine. Running on a Raspberry? Small cloud instance? No problem!
  • Project management: Besides Git hosting, Forgejo offers issues, pull requests, wikis, kanban boards and much more to coordinate with your team.
  • Publishing: Have something to share? Use releases to host your software for download, or use the package registry to publish it for docker, npm and many other package managers.
  • Customizable: Want to change your look? Change some settings? There are many config switches to make Forgejo work exactly like you want.
  • Powerful: Organizations & team permissions, CI integration, Code Search, LDAP, OAuth and much more. If you have advanced needs, Forgejo has you covered.
  • Privacy: From update checker to default settings: Forgejo is built to be privacy first for you and your crew.
  • Federation: (WIP) We are actively working to connect software forges with each other through ActivityPub, and create a collaborative network of personal instances.

Learn more

Dive into the documentation, subscribe to releases and blog post on our website, find us on the Fediverse or hop into our Matrix room if you have any questions or want to get involved.

License

Forgejo is distributed under the terms of the GPL version 3.0 or any later version.

The agreement for this license was documented in June 2023 and implemented during the development of Forgejo v9.0. All Forgejo versions before v9.0 are distributed under the MIT license.

Get involved

If you are interested in making Forgejo better, either by reporting a bug or by changing the governance, please take a look at the contribution guide.